Em 09-05-2011 16:54, stefan.ringel@xxxxxxxx escreveu:
> From: Stefan Ringel <stefan.ringel@xxxxxxxx>
>
> add pts logging
>
>
> Signed-off-by: Stefan Ringel <stefan.ringel@xxxxxxxx>
> ---
> drivers/staging/tm6000/tm6000-video.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c
> index 2d83204..4802396 100644
> --- a/drivers/staging/tm6000/tm6000-video.c
> +++ b/drivers/staging/tm6000/tm6000-video.c
> @@ -355,10 +355,14 @@ static int copy_streams(u8 *data, unsigned long len,
> case TM6000_URB_MSG_VBI:
> /* Need some code to copy vbi buffer */
> break;
> - case TM6000_URB_MSG_PTS:
> + case TM6000_URB_MSG_PTS: {
> /* Need some code to copy pts */
> + u32 pts;
> + pts = *(u32 *)ptr;
> + printk(KERN_INFO "%s: field %d, PTS %x", dev->name, field, pts);
Hmm... field may be unititialized... Please fix.
drivers/staging/tm6000/tm6000-video.c: In function ‘copy_streams’:
drivers/staging/tm6000/tm6000-video.c:231: warning: ‘field’ may be used uninitialized in this function
Also, it is not a good idea of just logging it. Instead, use enable logging only if debug is enabled
seems more appropriate.
Please send a patch fixing it.
Thanks,
Mauro.
> break;
> }
> + }
> }
> if (ptr + pktsize > endp) {
> /* End of URB packet, but cmd processing is not
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
