Hi Laurent, On Thu, May 19, 2011 at 3:14 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Sakari, > > On Thursday 19 May 2011 12:41:14 Sakari Ailus wrote: >> Hi, >> >> This patchset implements RFC v4 of V4L2 API for flash devices [1], with >> minor modifications, and adds the adp1653 flash controller driver. > > As already answered in private: > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx> Sorry if I missed something, but shouldn't be your ack here? :) The patches are from Sakari already. Br, David > >> This patchset depends on the bitmask controls patch [4]. >> >> Changes since v2 [3] of the RFC patchset: >> >> - Improved flash control documentation in general. >> >> - Faults may change the LED mode to none. This is now documented. >> >> - adp1653 is returned to sane after faults are detected. >> >> - Proper error handling for adp1653_get_fault() in adp1653_strobe(). >> >> - Remove useless function: adp1653_registered() and the corresponding >> Â callback. Controls are now initialised in adp1653_probe(). >> >> - Improved fault handling in adp1653_init_device(). >> >> Changes since v1 [2] of the RFC patchset: >> >> - Faults on the flash LED are allowed to make the LED unusable before >> the faults are read. This is implemented in the adp1653 driver. >> >> - Intensities are using standard units; mA for flash / torch and uA for >> the indicator. >> >> >> Thanks to those who have given their feedback so far in the process! >> >> >> [1] http://www.spinics.net/lists/linux-media/msg32030.html >> >> [2] http://www.spinics.net/lists/linux-media/msg32396.html >> >> [3] http://www.spinics.net/lists/linux-media/msg32436.html >> >> [4] http://www.spinics.net/lists/linux-media/msg31001.html > > -- > Regards, > > Laurent Pinchart > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
