On May 11, 2011, at 9:36 PM, Mauro Carvalho Chehab wrote: > Em 12-05-2011 03:10, Mauro Carvalho Chehab escreveu: >> Em 12-05-2011 02:37, Anssi Hannula escreveu: > >>> I don't see any other places: >>> $ git grep 'REP_PERIOD' . >>> dvb/dvb-usb/dvb-usb-remote.c: input_dev->rep[REP_PERIOD] = >>> d->props.rc.legacy.rc_interval; >> >> Indeed, the REP_PERIOD is not adjusted on other drivers. I agree that we >> should change it to something like 125ms, for example, as 33ms is too >> short, as it takes up to 114ms for a repeat event to arrive. >> > IMO, the enclosed patch should do a better job with repeat events, without > needing to change rc-core/input/event logic. > > - > > Subject: Use a more consistent value for RC repeat period > From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > > The default REP_PERIOD is 33 ms. This doesn't make sense for IR's, > as, in general, an IR repeat scancode is provided at every 110/115ms, > depending on the RC protocol. So, increase its default, to do a > better job avoiding ghost repeat events. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> Yeah, I definitely like this change, and I think it should do some good. I've been pointing a number of people at ir-keytable and its ability to tweak these values from userspace. Most people have been bumping REP_PERIOD up a bit, but also REP_DELAY down a bit, so that repeats actually kick in a bit sooner. I'm fine with leaving 500 as the default there though, and letting individual drivers adjust it if they really want. Acked-by: Jarod Wilson <jarod@xxxxxxxxxx> -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
