Re: [PATCH] [media] ite-cir: make IR receive work after resume

[Juan Jesús García de Soria Lucena <skandalfo@xxxxxxxxx>]

Hi Jarod, and thanks for looking at this.

El 09/05/2011 20:28, "Jarod Wilson" <jarod@xxxxxxxxxx> escribiÃ:
> --- a/drivers/media/rc/ite-cir.c
> +++ b/drivers/media/rc/ite-cir.c
> @@ -1684,6 +1684,8 @@ static int ite_resume(struct pnp_dev *pdev)
> Â Â Â Â Â Â Â Â/* wake up the transmitter */
> Â Â Â Â Â Â Â Âwake_up_interruptible(&dev->tx_queue);
> Â Â Â Â} else {
> + Â Â Â Â Â Â Â /* reinitialize hardware config registers */
> + Â Â Â Â Â Â Â dev->params.init_hardware(dev);
> Â Â Â Â Â Â Â Â/* enable the receiver */
> Â Â Â Â Â Â Â Âdev->params.enable_rx(dev);
> Â Â Â Â}
> --
> 1.7.1
>

But... wouldn't the hardware initialization be required too if the hardware got suspended while doing TX? I mean, probably the call to init_hardware() should be done in any case, just before the if... (forgive me if I'm off target; I'm looking at the code as I remember it, since I don't have it before me right now).

Best regards,

   Juan JesÃs.ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þg‰¯â^n‡r¡öë¨è&£ûz¹Þúzf£¢·hšˆ§~†­†Ûÿÿïÿ‘ê_èæ+v‰¨þ)ßø