Em 07-05-2011 04:22, Manoel PN escreveu:
> Hi everyone,
>
> I made several modifications on the driver for the MB86A20S demodulator and would like to receive comments regarding the modifications.
>
> The modifications were necessary to allow the use of other drivers, as what I'm finishing for the device "TBS Media JH DTB08 USB2.0 ISDB-T".
>
> Thanks for the comments, best regards,
Wow! huge changes! I'm currently travelling abroad without ISDB-T signal
here. I'll analyze and better comment your patch after my return. Anyway,
let me popup just two small thinks that come to me on a very quick look
on your patch:
> config DVB_MB86A20S
> - tristate "Fujitsu mb86a20s"
> + tristate "Fujitsu MB86A20S"
Why? we generally use lowercase for device codes.
Please, don't change it.
> +static struct mb86a20s_config_regs_param mb86a20s_config_default[] = {
> + { REG0001, 0x0d }, /* 0x0d */
> + { REG0009, 0x3e }, /* 0x1a */
NACK.
It makes no sense to rename for something as vague as "REG00001".
It would be ok if you had renamed, for someting with a meaning. Like, for example,
renaming reg 0x70 to something like: REG70_RESET_DEVICE
Also, please send renaming patches like that in separate, otherwise it becomes
really hard to discover what you've changed at the initialization sequence.
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
