Re: [git:v4l-dvb/for_v2.6.40] [media] Sony CXD2820R DVB-T/T2/C demodulator driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steve or Andreas can do it. I am now on holiday weekend, snowboarding maybe last time for this season :)

I cannot do much until next week. All help is welcome!

Antti
-- 
http://palosaari.fi/
----- Original message -----
> If antti doesn't do this before me, I will look at this over the weekend
> and generate a patch against antti's current code... if that's
> appropriate of course (I'm new at this ;))
> 
> Regards,
> Steve Kerrison.
> 
> ----- Reply message -----
> From: "Andreas Oberritter" <obi@xxxxxxxxxxx>
> Date: Fri, May 6, 2011 13:36
> Subject: [git:v4l-dvb/for_v2.6.40] [media] Sony CXD2820R DVB-T/T2/C
> demodulator driver To: "Mauro Carvalho Chehab" <mchehab@xxxxxxxxxx>
> Cc: "Steve Kerrison" <steve@xxxxxxxxxxxxxxxxx>,
> <linux-media@xxxxxxxxxxxxxxx>, "Antti Palosaari" <crope@xxxxxx>
> 
> 
> On 05/06/2011 02:23 PM, Mauro Carvalho Chehab wrote:
> > Em 06-05-2011 07:42, Steve Kerrison escreveu:
> > > Hi Andreas,
> > > 
> > > From cxd2820r_priv.h:
> > > 
> > > > +/*
> > > > + * FIXME: These are totally wrong and must be added properly to
> > > > the API. + * Only temporary solution in order to get driver
> > > > compile. + */
> > > > +#define SYS_DVBT2Â Â Â Â Â Â Â Â Â Â Â Â  SYS_DAB
> > > > +#define TRANSMISSION_MODE_1KÂ  0
> > > > +#define TRANSMISSION_MODE_16K 0
> > > > +#define TRANSMISSION_MODE_32K 0
> > > > +#define GUARD_INTERVAL_1_128Â  0
> > > > +#define GUARD_INTERVAL_19_128 0
> > > > +#define GUARD_INTERVAL_19_256 0
> > > 
> > > 
> > > I believe Antti didn't want to make frontent.h changes until a
> > > consensus was reached on how to develop the API for T2 support.
> > 
> > Yeah.
> > 
> > Andreas/Antti,
> > 
> > It seems more appropriate to remove the above hack and add Andreas
> > patch. I've reviewed it and it seemed ok on my eyes, provided that we
> > also update DVB specs to reflect the changes.
> > 
> > In special, the new DVB command should be documented:
> > ÂÂÂ +#define DTV_DVBT2_PLP_IDÂÂÂ 43
> 
> In addition to the patch, the PLP ID needs to be stored in struct
> dtv_frontend_properties and used by property cache functions in
> dvb_frontend.c.
> 
> Antti, could you please complete the patch and test it with your device?
> This patch was adapted from an older kernel and only compile-tested few
> weeks ago.
> 
> Regards,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux