On Wed, 04 May 2011 12:13:49 -0300, Mauro Carvalho Chehab
<maurochehab@xxxxxxxxx> wrote:
> Em 29-04-2011 05:08, David HÃrdeman escreveu:
>> diff --git a/drivers/media/rc/keymaps/rc-videomate-s350.c
>> b/drivers/media/rc/keymaps/rc-videomate-s350.c
>> index 26ca260..2f0ec1f 100644
>> --- a/drivers/media/rc/keymaps/rc-videomate-s350.c
>> +++ b/drivers/media/rc/keymaps/rc-videomate-s350.c
>> @@ -13,57 +13,56 @@
>> #include <media/rc-map.h>
>>
>> static struct rc_map_table videomate_s350[] = {
>> - { 0x00, KEY_TV},
...
>> + { RC_TYPE_UNKNOWN, RC_SCANCODE_UNKNOWN(0x00), KEY_TV},
>> };
> However, changes like the above makes the keymaps confusing and breaks
the
> v4l-utils sync scripts without a good reason.
First of all, I've missed that there are v4l-utils sync scripts.
Second of all, I think you can ignore this patch for now. It's actually a
much better idea to keep the rc_map and rc_map_table structs the way they
are (thereby reducing the patch size) and introduce new structs to be used
in rc_dev for maintaining the actual live keytable (and store the
protocol for each scancode in the new struct instead).
That way drivers/media/rc/keymaps/ won't see so much churn.
--
David HÃrdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
