Hi Simon, Em 04-05-2011 06:32, Simon Farnsworth escreveu: > On Tuesday 3 May 2011, Andy Walls <awalls@xxxxxxxxxxxxxxxx> wrote: >> Simon, >> >> If these two changes are going in, please also bump the driver version to >> 1.5.0 in cx18-version.c. These changes are significant enough >> perturbation. >> >> End users are going to look to driver version 1.4.1 as the first version >> for proper analog tuner support of the HVR1600 model 74351. >> >> Mauro, >> >> Is cx18 v1.4.1 with HVR1600 model 74351 analog tuner support, without these >> mmap() changes going to be visible in kernel version .39 ? >> > > Mauro, > > If you're going to accept these two patches, would you mind bumping the > version in cx18-version.c for me as you apply them, or would you prefer me to > provide either an incremental patch or a new patch with the bump added? There are a few new warnings with your code: drivers/media/video/cx18/cx18-mailbox.c: In function ‘cx18_mdl_send_to_videobuf’: drivers/media/video/cx18/cx18-mailbox.c:206: warning: passing argument 1 of ‘ktime_get_ts’ from incompatible pointer type include/linux/ktime.h:331: note: expected ‘struct timespec *’ but argument is of type ‘struct timeval *’ drivers/media/video/cx18/cx18-mailbox.c:170: warning: unused variable ‘i’ drivers/media/video/cx18/cx18-mailbox.c:167: warning: unused variable ‘u’ Could you please fix them? Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
