Hi Simon, On Tuesday, May 03, 2011 13:57:40 Simon Farnsworth wrote: > The initial version of this patch (commit > d5976931639176bb6777755d96b9f8d959f79e9e) had some issues: > > * It didn't correctly calculate the size of the YUV buffer for 4:2:2, > resulting in capture sometimes being offset by 1/3rd of a picture. > > * There were a lot of variables duplicating information the driver > already knew, which have been removed. > > * There was an in-kernel format conversion - libv4l can do this one, > and is the right place to do format conversions anyway. > > * Some magic numbers weren't properly explained. > > Fix all these issues, leaving just the move from videobuf to videobuf2 > to do. > > Signed-off-by: Simon Farnsworth <simon.farnsworth@xxxxxxxxxxxx> I just wanted to thank you for your work. I hope I never gave the impression that the whole discussion had anything to do with you. You were just unlucky enough to trigger a 'to merge or not to merge' and a 'to vb2 or not to vb2' discussion through no fault of your own. Just thought I should mention that. I would definitely like to see cx18 working with tvtime and it is valuable work you are doing. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
