On Mon, May 2, 2011 at 3:35 PM, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> wrote: > Em 02-05-2011 16:11, Hans Verkuil escreveu: >> NACK. >> >> For two reasons: first of all it is not signed off by Andy Walls, the cx18 >> maintainer. I know he has had other things on his plate recently which is >> probably why he hasn't had the chance to review this. >> >> Secondly, while doing a quick scan myself I noticed that this code does a >> conversion from UYVY format to YUYV *in the driver*. Format conversion is >> not allowed in the kernel, we have libv4lconvert for that. So at the minimum >> this conversion code must be removed first. > > Patch is there at the ML since Apr, 6 and nobody acked/nacked it. If you or > andy were against it, why none of you commented it there? > > Now that the patch were committed, I won't revert it without a very good reason. > > With respect to the "conversion from UYVY format to YUYV", a simple patch could > fix it, instead of removing the entire patchset. > > Steven/Simon, > could you please work on such change? Simon, If you're willing to do a bit of work to actually prepare the patch and test the results, I can walk you through pretty much exactly what needs to change (basically you just need to remove one block of code and change a #define). Steven has been really busy with other stuff, so I don't think we should count on his participation in this process. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
