Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans de Goede wrote:
> Hi,

Hi Hans, Yordan,

> First of all my apologies for taking so long to get around to
> reviewing this.
> 
> Over all it looks good, I've put some small remarks inline, if
> you fix these I can merge this. I wonder though, given the recent
> limbo around Nokia's change of focus, if there are any plans to
> actually move forward with a plugin using this... ?

Yes, there are. That hasn't changed a bit.

> The reason I'm asking is that adding the plugin framework if nothing
> is going to use it seems a bit senseless.

I agree with that. I also hope others would find the plugin framework
useful as well. :-)

A minor comment on the patch itself: there are a few checkpatch.pl
warnings from it, mostly lines over 80 characters, but also others.

Cheers,

-- 
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux