On Tue, 19 Apr 2011, Akira Tsukamoto wrote: > Hello Guennadi, > > > > > static struct i2c_board_info i2c0_devices[] = { > > > > { > > > > I2C_BOARD_INFO("ag5evm_ts", 0x20), > > > > .irq = pint2irq(12), /* PINTC3 */ > > > > }, > > > > + /* 2M camera */ > > > > + { > > > > + I2C_BOARD_INFO("rj65na20", 0x40), > > > > + }, > > > > > > No, you do not have to include this here, the sensor must not be registered > > > automatically during the board initialisation. > > I have one more question before sleeping :) > > The camera module needs to be initialized by writing values to the registers. > Do I need to write init function at the following? > > static const struct v4l2_subdev_core_ops rj65na20_core_ops = { > .reset = rj65na20_reset, > [snip] > } AFAICS neither soc_camera.c, nor sh_mobile_ceu_camera.c call the .reset subdevice core method, so, no, at the moment implementing it wouldn't produce any result. Either you have to choose one of the methods, that are currently called, or you have to add a call to .reset() as required. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html