On Apr 11, 2011, at 6:57 PM, Márcio Alves wrote: > patch to cx231xx: add support for Kworld UB430 > Signed-off-by: Márcio A Alves <froooozen@xxxxxxxxx> > > diff -upr ../new_build2/linux//drivers/media/dvb/dvb-usb/dvb-usb-ids.h linux//drivers/media/dvb/dvb-usb/dvb-usb-ids.h > --- ../new_build2/linux//drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2011-02-28 01:45:23.000000000 -0300 > +++ linux//drivers/media/dvb/dvb-usb/dvb-usb-ids.h 2011-04-11 14:23:31.836858001 -0300 > @@ -125,6 +125,7 @@ > #define USB_PID_GRANDTEC_DVBT_USB_COLD 0x0fa0 > #define USB_PID_GRANDTEC_DVBT_USB_WARM 0x0fa1 > #define USB_PID_INTEL_CE9500 0x9500 > +#define USB_PID_KWORLD_UB430 0xe424 > #define USB_PID_KWORLD_399U 0xe399 > #define USB_PID_KWORLD_399U_2 0xe400 > #define USB_PID_KWORLD_395U 0xe396 That addition does nothing, since cx231xx-*.c don't include that header. Its only for use by drivers under dvb-usb/. Just leave this out. ... > diff -upr ../new_build2/linux//drivers/media/video/cx231xx/cx231xx.h linux//drivers/media/video/cx231xx/cx231xx.h > --- ../new_build2/linux//drivers/media/video/cx231xx/cx231xx.h 2011-03-11 13:25:49.000000000 -0300 > +++ linux//drivers/media/video/cx231xx/cx231xx.h 2011-04-11 14:20:30.616858003 -0300 > @@ -64,7 +64,8 @@ > #define CX231XX_BOARD_HAUPPAUGE_EXETER 8 > #define CX231XX_BOARD_HAUPPAUGE_USBLIVE2 9 > #define CX231XX_BOARD_PV_PLAYTV_USB_HYBRID 10 > -#define CX231XX_BOARD_PV_XCAPTURE_USB 11 > +#define CX231XX_BOARD_KWORLD_UB430_USB_HYBRID 11 > +#define CX231XX_BOARD_PV_XCAPTURE_USB 12 > > /* Limits minimum and default number of buffers */ > #define CX231XX_MIN_BUF 4 You should add to the end of the list, as device 12, not move an already existing device. Those two minor nits aside, the patch looks sane. -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
