On 4/11/11, Jarod Wilson <jarod@xxxxxxxxxxxx> wrote: > So I was just circling back around on this one, and took some time to read > the actual code and the radio support addition. After doing so, I don't > see why the patch I proposed wouldn't do. The buffer is only manipulated > if !dev->radio or if vbuf is non-NULL (the memcpy call). If its initialized > to NULL, it only gets used exactly as it did before 8aff8ba9 when > !dev->radio, and if its not been used or its NULL following manipulations > protected by !dev->radio, it doesn't get copied. What is the "real bug" I > am missing there? (Or did I already miss a patch posted to linux-media > addressing it?) > My laptop was stolen so I can't review code for the next couple weeks. I remember that I thought your patch looked correct, but I was hoping that Dmitri would Ack it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
