Hi Hans, On Friday 08 April 2011 17:39:01 Hans Verkuil wrote: > On Friday, April 08, 2011 17:10:32 Laurent Pinchart wrote: > > On Monday 04 April 2011 13:51:48 Hans Verkuil wrote: > > > From: Hans Verkuil <hverkuil@xxxxxxxxx> > > > > > > This is required to implement control events and is also needed to > > > allow for per-filehandle control handlers. > > > > Thanks for the patch. > > > > Shouldn't you modify v4l2-subdev.c similarly ? > > Good question. Does it make sense to have per-filehandle controls for a > sub-device? On the other hand, does it make sense NOT to have it? Yes, I think it does. I wrote support for per-file handler controls for subdevs and submitted an RFC patch to the list some time ago to implement bandwidth managemeng in the OMAP3 ISP driver (this has been put on hold due to missing information about the OMAP3 ISP though). > I'm inclined to add this functionality if nobody objects. Although a > use-case for this would be nice bonus. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html