Hi Jonghun, On 04/06/2011 02:37 AM, Jonghun Han wrote: ... > > Hi Marek, > > runtime_pm is used to minimize current. > In my opinion, the followings will be better. > 1. Adds pm_runtime_get_sync before running of the first job. > IMO, dma_run callback function is the best place for calling in case of > M2M. Yeah, sounds reasonable. > 2. And then in the ISR, call pm_runtime_put_sync in the ISR bottom-half if > there is no remained job. So you are switching the clocks off in the interrupt context, I'm not sure whether this is a good idea. Perhaps we could just use pm_runtime_put() in this case? > > I had already implemented and tested. > But it remained code cleanup. I hope I can post it on the next week. The purpose of Marek's simple patch was to just enable the FIMC IP to illustrate the IOMMU driver's operation. I have prepared more complete patch for runtime PM and system suspend/resume in the mem-to-mem driver as well, but I want to consolidate this with the video capture driver before sending upstream. Anyway I'm looking forward to see your patch so we can work out some common version. Also I've got a few patches for this rc period which I intend to post this week. Regards, -- Sylwester Nawrocki Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
