Hi heungjun, I have tested this version for a few days. On 03/16/2011 10:30 PM, Kim, Heungjun wrote: > -----Original Message----- > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Kim, Heungjun > Sent: Wednesday, March 16, 2011 10:39 PM > To: linux-media@xxxxxxxxxxxxxxx > Cc: hverkuil@xxxxxxxxx; laurent.pinchart@xxxxxxxxxxxxxxxx; Kim, > Heungjun; Sylwester Nawrocki; Kyungmin Park > Subject: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera > > Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated > image signal processor. > > Signed-off-by: Heungjun Kim <riverful.kim@xxxxxxxxxxx> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > > Hi Hans and everyone, > > This is sixth version of M-5MOLS 8 Mega Pixel camera sensor. And, if > you see > previous version, you can find at: > http://www.spinics.net/lists/linux-media/msg29350.html > > This driver patch is fixed several times, and the important issues is > almost > corrected. And, I hope that this is the last version one merged for > 2.6.39. > I look forward to be reviewed one more time. > > The summary of this version's feature is belows: > > 1. Add focus control > : I've suggest menu type focus control, but I agreed this > version is > not yet the level accepted. So, I did not use focus control > which > I suggest. > The M-5MOLS focus routine takes some time to execute. But, the > user > application calling v4l2 control, should not hanged while > streaming > using q/dqbuf. So, I use workqueue. I want to discuss the focus > subject on mailnglist next time. > I wonder this feature is dependent on this firmware version? .....snip > +static int m5mols_start_monitor(struct v4l2_subdev *sd) > +{ > + struct m5mols_info *info = to_m5mols(sd); > + int ret; > + > + ret = m5mols_set_mode(sd, MODE_PARAM); > + if (!ret) > + ret = i2c_w8_param(sd, CAT1_MONITOR_SIZE, info- > >res_preset); > + if (!ret) > + ret = i2c_w8_param(sd, CAT1_MONITOR_FPS, info->fps_preset); > + if (!ret) > + ret = m5mols_set_mode(sd, MODE_MONITOR); > + if (!ret && info->do_once) { > + /* After probing the driver, this should be callde once. > */ > + v4l2_ctrl_handler_setup(&info->handle); As test result, When sensor is set monitor mode, if this API is called, Preview data(get from sensor) is craked. Surely, it is good working if this API is called in paramset mode. That waw no problem in Version 5. Because it is returned before v4l2_ctrl_handler_init() In m5mols_init_controls(version 5) : ret = i2c_r16_ae(sd, CAT3_MAX_GAIN_MON, (u32 *)&max_ex_mon); if (ret) return ret; // if success, return. My test case is : S_power->s_fmt->s_stream. ..... BRs Sungchun. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
