Re: vb2_plane 'mapped' signed bit field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(Originally sent to Pawel's Samsung address that bounced)

* Dr. David Alan Gilbert (linux@xxxxxxxxxxx) wrote:
> Hi Pawel,
>   'sparse' spotted that vb2_plane's mapped field is a signed
> bitfield:
> 
> include/media/videobuf2-core.h:78:41 1 bit signed int
> 
> struct vb2_plane {
>        void                    *mem_priv;
>        int                     mapped:1;
> };
> 
> that probably should be an unsigned int (I can see code that assigns
> 1 to it that just won't fit).
> 
> (Introduced by e23ccc0ad9258634e6d52cedf473b35dc34416c7 , spotted in
> 2.6.39-rc1 )
> 
> Dave
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \ gro.gilbert @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\ gro.gilbert @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux