Re: [PATCH 3/3] ARM: switch mackerel to dynamically manage the platform camera

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 21, 2011 at 10:22 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> On Wed, 16 Mar 2011, Magnus Damm wrote:
>
>> On Tue, Feb 22, 2011 at 6:57 PM, Guennadi Liakhovetski
>> <g.liakhovetski@xxxxxx> wrote:
>> > Use soc_camera_platform helper functions to dynamically manage the
>> > camera device.
>> >
>> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
>> > ---
>> >  arch/arm/mach-shmobile/board-mackerel.c |   28 +++++++---------------------
>> >  1 files changed, 7 insertions(+), 21 deletions(-)
>>
>> I just tested patch 1/3 and patch 3/3 on my Mackerel board.
>
> Thanks for testing!
>
>> Unfortunately I get this printout on the console:
>>
>> sh_mobile_ceu sh_mobile_ceu.0: SuperH Mobile CEU driver attached to camera 0
>> soc_camera_platform soc_camera_platform.0: Platform has not set
>> soc_camera_device pointer!
>> soc_camera_platform: probe of soc_camera_platform.0 failed with error -22
>> sh_mobile_ceu sh_mobile_ceu.0: SuperH Mobile CEU driver detached from camera 0
>>
>> Without these two patches everything work just fine. Any ideas on how
>> to fix it? I'd be happy to test V2. =)
>
> Hm, yes, looks like I'm initialising the pointer too late. Could you,
> please, test the patch below on top, if it helps, I'll send v2.

Yes, this fix incremental change solves the problem. Thanks!

Please post V2 and add:

Acked-by: Magnus Damm <damm@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux