Re: [PATCH] fix of mutex locking bug in fops_read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>

On Tue, Mar 15, 2011 at 6:03 AM, Tobias Lorenz <tobias.lorenz@xxxxxxx> wrote:
> This patch fixes a mutex locking bug causing userspace processes
> to hang indefinitely upon reading the radio device for RDS data.
>
> Signed-off-by: Nils Faerber <nils.faerber@xxxxxxxxxxxxxxxxx>
> Acked-by: Tobias Lorenz <tobias.lorenz@xxxxxxx>
> ---
>  drivers/media/radio/si470x/radio-si470x-common.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/radio/si470x/radio-si470x-common.c
> b/drivers/media/radio/si470x/radio-si470x-common.c
> index 4c69698..41ee757 100644
> --- a/drivers/media/radio/si470x/radio-si470x-common.c
> +++ b/drivers/media/radio/si470x/radio-si470x-common.c
> @@ -483,7 +483,6 @@ static ssize_t si470x_fops_read(struct file *file,
> char __user *buf,
>        count /= 3;
>
>        /* copy RDS block out of internal buffer and to user buffer */
> -       mutex_lock(&radio->lock);
>        while (block_count < count) {
>                if (radio->rd_index == radio->wr_index)
>                        break;
> --
> 1.7.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux