On Sun, 6 Mar 2011 13:06:09 +0100 Oliver Neukum <oliver@xxxxxxxxxx> wrote: > Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler: > > This should fix warnings seen by some: > > WARNING: at lib/dma-debug.c:866 check_for_stack > > > > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977. > > Reported-by: Zdenek Kabelac <zdenek.kabelac@xxxxxxxxx> > > Signed-off-by: Florian Mickler <florian@xxxxxxxxxxx> > > CC: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx> > > CC: linux-media@xxxxxxxxxxxxxxx > > CC: linux-kernel@xxxxxxxxxxxxxxx > > CC: Greg Kroah-Hartman <greg@xxxxxxxxx> > > CC: Rafael J. Wysocki <rjw@xxxxxxx> > > CC: Maciej Rutecki <maciej.rutecki@xxxxxxxxx> > > --- > > > > Please take a look at it, as I do not do that much kernel hacking > > and don't wanna brake anybodys computer... :) > > > > From my point of view this should _not_ go to stable even though it would > > be applicable. But if someone feels strongly about that and can > > take responsibility for that change... > > The patch looks good and is needed in stable. > It could be improved by using a buffer allocated once in the places > you hold a mutex anyway. > > Regards > Oliver Ok, I now put a buffer member in the priv dib0700_state which gets allocated on the heap. My patch introduces a new error condition in the dib0700_identify_state callback which gets not checked for in dvb_usb_find_device... Should we worry? Same for dib0700_get_version in the probe callback... But there, there was already the possibility of usb_control_msg returning an error... Regards, Flo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
