Hi,
On Monday 28 February 2011 06:15:23 Kim, HeungJun wrote:
> 2011-02-25 ìí 9:58, Laurent Pinchart ì ê:
> > On Friday 25 February 2011 13:46:01 Kim, HeungJun wrote:
> >> As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu
> >> type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO.
> >>
> >> Signed-off-by: Heungjun Kim <riverful.kim@xxxxxxxxxxx>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> >> ---
> >>
> >> drivers/media/video/uvc/uvc_ctrl.c | 9 ++++++++-
> >> 1 files changed, 8 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/media/video/uvc/uvc_ctrl.c
> >> b/drivers/media/video/uvc/uvc_ctrl.c index 59f8a9a..b98b9f1 100644
> >> --- a/drivers/media/video/uvc/uvc_ctrl.c
> >> +++ b/drivers/media/video/uvc/uvc_ctrl.c
> >> @@ -333,6 +333,11 @@ static struct uvc_menu_info
> >> exposure_auto_controls[] = { { 8, "Aperture Priority Mode" },
> >>
> >> };
> >>
> >> +static struct uvc_menu_info focus_auto_controls[] = {
> >> + { 1, "Auto Mode" },
> >> + { 0, "Manual Mode" },
> >
> > Now that manual focus has value 0 and auto focus value 1, the menu
> > entries need to be the other way around.
>
> I don't really get it. My understanding is that your words are structure
> uvc_menu_info should be changed as fitted to focus menu type. right?
> But, I thinks they don't need to be changed, and I don't find wrong,
> I don't know how to fix what you telling me exactly.
>
> So, could you explain more details? Some examples helps to me.
The menu entries are indexed by the V4L2 menu value. The first field is the
UVC menu entry value, and the second field its name. As the V4L2 manual focus
control has a value of 0, it must be the first entry.
> Sorry to bother if you are busy, but it's good for me your advice.
> I'll waiting.
No worries.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
