Re: [PATCH 5/9 v2] ds3000: clean up in tune procedure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ð ÑÐÐÐÑÐÐÐÐ ÐÑ 25 ÑÐÐÑÐÐÑ 2011 01:33:41 ÐÐÑÐÑ Mauro Carvalho Chehab ÐÐÐÐÑÐÐ:
> Em 24-02-2011 17:25, Igor M. Liplianin escreveu:
> > Ð ÑÐÐÐÑÐÐÐÐ ÐÑ 24 ÑÐÐÑÐÐÑ 2011 21:11:13 ÐÐÑÐÑ Mauro Carvalho Chehab ÐÐÐÐÑÐÐ:
> >> Em 24-02-2011 16:04, Mauro Carvalho Chehab escreveu:
> >>> Hi Igor,
> >>> 
> >>> Em 01-02-2011 20:40, Igor M. Liplianin escreveu:
> >>>> Variable 'retune' does not make sense.
> >>>> Loop is not needed for only one try.
> >>>> Remove unnecessary dprintk's.
> >>>> 
> >>>> Signed-off-by: Igor M. Liplianin <liplianin@xxxxx>
> >>> 
> >>> This patch didn't apply. Please fix and resend.
> >> 
> >> PS.: I won't try to apply patches 7, 8 and 9, as they are all related to
> >> tune changes. They'll probably fail to apply, and, even if not failing
> >> or if I fix the conflicts, they may be breaking the driver. So, please
> >> put them on your next patch series.
> >> 
> >> thanks!
> >> Mauro
> > 
> > Hi Mauro,
> > 
> > Will do tonight.
> 
> OK.
> 
> > BTW, Why did you dropp/miss dw2102 patches?
> > They was sent before ds3000 series.
> 
> I probably missed, or they are still on my queue. While in general I apply
> patches in order, sometimes I reorder them, trying to merge first the more
> trivial ones (or the ones that I had already analyzed, like the altera
> ones). Please take a look at Patchwork. If they're there, then I'll
> probably be handling until the weekend. Otherwise, just re-send them to
> me.
Patches you already included are OK, but 5 to 9 needs(and depend) to be applied after dw2102 
series. I can rebase in differend order, but what's a matter?
I will create git tree somwere (probably at assembla), push there and send you pull request.

> 
> That's said, it is probably a good idea if you could have a git repository
> somewhere to send me patches. Git works better when there are lots of
> patches, so, works better for driver maintainers. If you want, I may
> create you an account at LinuxTV (or you may host it on any other place).
I will appreciate you very much if you create it for me, as I have a lot of stuff to commit.

Thank you in advance.
Igor
> 
> Thanks,
> Mauro
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Igor M. Liplianin
Microsoft Windows Free Zone - Linux used for all Computing Tasks
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux