Em 22-02-2011 04:53, Hans Verkuil escreveu:
> Actually, v4l2-ctrl and qv4l2 handle 'holes' correctly. I think this is a
> different bug relating to the handling of V4L2_CTRL_FLAG_NEXT_CTRL. Can you
> try this patch:
>
> diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
> index ef66d2a..15eda86 100644
> --- a/drivers/media/video/v4l2-ctrls.c
> +++ b/drivers/media/video/v4l2-ctrls.c
> @@ -1364,6 +1364,8 @@ EXPORT_SYMBOL(v4l2_queryctrl);
>
> int v4l2_subdev_queryctrl(struct v4l2_subdev *sd, struct v4l2_queryctrl *qc)
> {
> + if (qc->id & V4L2_CTRL_FLAG_NEXT_CTRL)
> + return -EINVAL;
> return v4l2_queryctrl(sd->ctrl_handler, qc);
Ok, this fixed the issue:
brightness (int) : min=0 max=255 step=1 default=128 value=128
contrast (int) : min=0 max=255 step=1 default=128 value=128
saturation (int) : min=0 max=255 step=1 default=128 value=128
hue (int) : min=-128 max=127 step=1 default=0 value=0
volume (int) : min=0 max=65535 step=655 default=58880 value=65500 flags=slider
balance (int) : min=0 max=65535 step=655 default=32768 value=32750 flags=slider
bass (int) : min=0 max=65535 step=655 default=32768 value=32750 flags=slider
treble (int) : min=0 max=65535 step=655 default=32768 value=32750 flags=slider
mute (bool) : default=0 value=0
loudness (bool) : default=0 value=0
Also, v4l2-compliance is now complaining less about it.
Control ioctls:
fail: does not support V4L2_CTRL_FLAG_NEXT_CTRL
test VIDIOC_QUERYCTRL/MENU: FAIL
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: Not Supported
Standard Controls: 0 Private Controls: 0
(yet, it is showing "standard controls = 0").
Could you provide your SOB to the above patch?
Thanks!
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
