On Mon, Feb 21, 2011 at 01:05:51PM +0200, Alexey Dobriyan wrote: > On Mon, Feb 21, 2011 at 12:20 PM, David Cohen <dacohen@xxxxxxxxx> wrote: > > Currently sched.h and wait.h have circular dependency between both. > > wait.h defines macros wake_up*() which use macros TASK_* defined by > > sched.h. But as sched.h indirectly includes wait.h, such wait.h header > > file can't include sched.h too. The side effect is when some file > > includes wait.h and tries to use its wake_up*() macros, it's necessary > > to include sched.h also. > > This patch moves all TASK_* macros from linux/sched.h to a new header > > file linux/task_sched.h. This way, both sched.h and wait.h can include > > task_sched.h and fix the circular dependency. No need to include sched.h > > anymore when wake_up*() macros are used. > > Just include <linux/sched.h> in your driver. > This include splitting in small pieces is troublesome as well. so, simply to call wake_up*() we need to know everything there is to know about the scheduler ? I rather have the split done and kill the circular dependency. What does Mingo and Peter think about this ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
