> This looks good now, thanks, I'll queue it for 2.6.39. Just > one question: > > On Thu, 17 Feb 2011, achew@xxxxxxxxxx wrote: > > > From: Andrew Chew <achew@xxxxxxxxxx> > > > > This soc_camera driver is for Omnivision's OV9740 sensor. > This initial > > submission provides support for YUV422 output at 1280x720 > (720p), which is > > the sensor's native resolution. 640x480 (VGA) is also > supported, with > > cropping and scaling performed by the sensor's ISP. > > Didn't you mean to say just "scaling?" You're not > implementing cropping. > You could, certainly, fake scaling with cropping, but are you > really using > both to switch between 720p and VGA? No need for a v5, just > tell me how to > change the comment. There really is cropping. The native resolution of the OV9740 sensor is a different aspect ratio than VGA. To preserve the square pixels, first we crop both the left and right sides, and then scale down.-- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
