Re: [PATCH v19 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 15, 2011 at 10:13:46AM +0200, Matti J. Aaltonen wrote:

>  	if (core->i2s_mode != mode) {
> -		r = wl1273_fm_write_cmd(core, WL1273_I2S_MODE_CONFIG_SET, mode);
> +		r = core->write(core, WL1273_I2S_MODE_CONFIG_SET, mode);

I'm having a hard time loving the replacement of the function with the
direct dereference from the struct but overall this is a good win so:

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux