On Mon, 2011-02-14 at 12:03 +0100, Tejun Heo wrote: > Hello, > > On Sun, Feb 13, 2011 at 08:33:55PM -0800, Dmitry Torokhov wrote: > > > The cx23885 driver does in fact schedule work for IR input handling: > > > > > > Here's where it is scheduled for CX23888 chips: > > > > > > http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-ir.c;h=7125247dd25558678c823ee3262675570c9aa630;hb=HEAD#l76 > > > > > > Here's where it is scheduled for CX23885 chips: > > > > > > http://git.linuxtv.org/media_tree.git?a=blob;f=drivers/media/video/cx23885/cx23885-core.c;h=359882419b7f588b7c698dbcfb6a39ddb1603301;hb=HEAD#l1861 > > Ah, sorry about missing those. There's a lot of indirection in drivers under drivers/media/video so it doesn't surprise me when someone misses something. (BTW, I only checked cx23885 since I wrote the IR handling and added the work queue usage for IR that driver.) > > > So what should be done about the flush_scheduled_work()? I think it > > > belongs there. > > > > > > > Convert to using threaded irq? Too big of a regression testing job for me to take on at the moment. > Or > > 1. Just flush the work items explicitly using flush_work_sync(). That will do for now. > 2. Create a dedicated workqueue to serve as flushing domain. I have gotten reports of the IR Rx FIFO overflows for the CX23885 IR Rx unit (the I2C connected one). I eventually should either set the Rx FIFO service interrupt watermark down from 4 measurments to 1 measurment, or use a kthread_worker with some higher priority to respond to the IR Rx FIFO service interrupt. > The first would look like the following. Does this look correct? Yes, your patch below looks sane to me. Reviewed-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx> Thanks, Andy > Thanks. > > diff --git a/drivers/media/video/cx23885/cx23885-input.c b/drivers/media/video/cx23885/cx23885-input.c > index 199b996..e27cedb 100644 > --- a/drivers/media/video/cx23885/cx23885-input.c > +++ b/drivers/media/video/cx23885/cx23885-input.c > @@ -229,6 +229,9 @@ static void cx23885_input_ir_stop(struct cx23885_dev *dev) > v4l2_subdev_call(dev->sd_ir, ir, rx_s_parameters, ¶ms); > v4l2_subdev_call(dev->sd_ir, ir, rx_g_parameters, ¶ms); > } > + flush_work_sync(&dev->cx25840_work); > + flush_work_sync(&dev->ir_rx_work); > + flush_work_sync(&dev->ir_tx_work); > } > > static void cx23885_input_ir_close(struct rc_dev *rc) > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
