On Mon, Feb 14, 2011 at 3:50 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Felipe, Hello, > > On Monday 14 February 2011 14:41:16 Felipe Balbi wrote: >> On Mon, Feb 14, 2011 at 02:19:24PM +0100, Laurent Pinchart wrote: >> > On Monday 14 February 2011 13:35:59 Felipe Balbi wrote: >> > > On Mon, Feb 14, 2011 at 01:21:31PM +0100, Laurent Pinchart wrote: >> > > > diff --git a/arch/arm/mach-omap2/devices.c >> > > > b/arch/arm/mach-omap2/devices.c index 4cf48ea..5d844bd 100644 >> > > > --- a/arch/arm/mach-omap2/devices.c >> > > > +++ b/arch/arm/mach-omap2/devices.c >> > > > @@ -38,7 +38,7 @@ >> > > > >> > > > Â#if defined(CONFIG_VIDEO_OMAP2) || >> > > > Âdefined(CONFIG_VIDEO_OMAP2_MODULE) >> > > > >> > > > -static struct resource cam_resources[] = { >> > > > +static struct resource omap2cam_resources[] = { >> > > >> > > should this be __initdata ?? >> > >> > The resources will be used when the OMAP3 ISP module is loaded. Won't >> > they be discared if marked as __initdata ? >> >> I believe driver core makes a copy of those, no ? not sure. > > Not that I know of, but I may be wrong. I don't think omap2cam_resources would be used at all. AFAIK, it belongs to omap2xxcam, isn't it? :) Br, David -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html