Re: [PATCH v6 02/10] omap3: Remove unusued ISP CBUFF resource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Felipe,

On Monday 14 February 2011 13:31:06 Felipe Balbi wrote:
> On Mon, Feb 14, 2011 at 01:21:29PM +0100, Laurent Pinchart wrote:
> > From: Sergio Aguirre <saaguirre@xxxxxx>
> > 
> > The ISP CBUFF module isn't use, its resource isn't needed.
> > 
> > Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> it's unused but it's there right ? what's the problem in keeping it ?
> maybe you'd like to add name for the resources as well, there are many
> of them and keeping the order correct might be difficult. You can move
> to platform_get_resource_byname() on drivers.

But if it's unused, why keep it ? :-) There are other resources present on the 
chip (especially on older silicon versions) that are completely unused and 
even undocumented. They're not defined either.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux