On Tue, 2011-02-01 at 13:49 -0200, Mauro Carvalho Chehab wrote: > Hi Lawrence, > > Em 08-01-2011 16:45, Lawrence Rust escreveu: > > Thanks for the info on the PVR-150. It largely confirmed what I had > > surmised - that the two cards disagree about serial audio data format. > > Before my patch, the wm8775 was programmed for Philips mode but the > > CX25843 on the PVR-150 is setup for Sony I2S mode!! On the Nova-S, the > > cx23883 is setup (in cx88-tvaudio.c) for Philips mode. The patch > > changed the wm8775 to Sony I2S mode because the existing setup gave > > noise, indicative of a mismatch. > > > > It is my belief that either the wm8775 datasheet is wrong or there are > > inverters on the SCLK lines between the wm8775 and cx25843/23883. It is > > also plausible that Conexant have it wrong and both their datasheets are > > wrong. > > > > Anyway, I have revised the patch (attached) so that the wm8775 is kept > > in Philips mode (to please the PVR-150) and the cx23883 on the Nove-S is > > now switched to Sony I2S mode (like the PVR-150) and this works fine. > > The change is trivial, just 2 lines, so they're shouldn't be any other > > consequences. However, could this affect any other cards? > > > > NB I have only tested this patch on my Nova-S, no other. > > As it was pointed, your patch affects other boards with wm8775. In order > to avoid it, you need to use platform_data to pass nova_s specific parameters, > and be sure that other boards won't be affected by your changes. > > As you might not be able to see how this should be written, I modified your > patch in a way that, hopefully, it won't affect PVR-150. Please test. Many thanks for doing this. I appreciate the guidance and effort. I'll test it and report back this weekend. -- Lawrence -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
