Re: [PATCH] v4l: mx3_camera: fix NULL pointer dereference if debug output enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2 Feb 2011, Guennadi Liakhovetski wrote:

> On Mon, 31 Jan 2011, Anatolij Gustschin wrote:
> 
> > Running with enabled debug output in the mx3_camera driver results
> > in a kernel crash:
> > ...
> > mx3-camera mx3-camera.0: Providing format Bayer BGGR (sRGB) 8 bit using code 11
> > Unable to handle kernel NULL pointer dereference at virtual address 00000004
> > ...
> > 
> > Fix it by incrementing 'xlate' after usage.
> > 
> > Signed-off-by: Anatolij Gustschin <agust@xxxxxxx>
> > ---
> >  drivers/media/video/mx3_camera.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c
> > index b9cb4a4..7bcaaf7 100644
> > --- a/drivers/media/video/mx3_camera.c
> > +++ b/drivers/media/video/mx3_camera.c
> > @@ -734,9 +734,9 @@ static int mx3_camera_get_formats(struct soc_camera_device *icd, unsigned int id
> >  	if (xlate) {
> >  		xlate->host_fmt	= fmt;
> >  		xlate->code	= code;
> > -		xlate++;
> >  		dev_dbg(dev, "Providing format %x in pass-through mode\n",
> >  			xlate->host_fmt->fourcc);
> > +		xlate++;
> 
> Let's take an even easier path:
> 
> -			xlate->host_fmt->fourcc);
> +			fmt->fourcc);

Ok, sorry, forget it - this entire patch is superseded by another one.

Guennadi

> 
> 
> >  	}
> >  
> >  	return formats;
> > -- 
> > 1.7.1
> 
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski
> 

---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux