Re: [PATCH 04/13] [media] rc/keymaps: Use KEY_LEFTMETA were pertinent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 24, 2011, at 11:08 AM, Mauro Carvalho Chehab wrote:

> Em 24-01-2011 13:45, Jarod Wilson escreveu:
>> On Jan 24, 2011, at 10:18 AM, Mauro Carvalho Chehab wrote:
>> 
>>> Using xev and testing the "Windows" key on a normal keyboard, it
>>> is mapped as KEY_LEFTMETA. So, as this is the standard code for
>>> it, use it, instead of a generic, meaningless KEY_PROG1.
>> 
>> Not sure I agree with this change, or at least, not with using
>> KEY_LEFTMETA. The Window MCE key isn't quite analogous to the Windows
>> key on a keyboard. Under Windows, I'm pretty sure its a program
>> launcher key, that launches (or switches you to) the Windows Media
>> Center UI.
> 
> If you look from userspace perspective, an application that will use
> the media keycodes need to have a proper behaviour for each of the
> received keys.
> 
> The idea is that each media key should be translated into a X key.
> My idea is to add something like:
> 
> #define XK_10channelsdown    0xfc00	/* KEY_10CHANNELSDOWN */
> #define XK_10channelsup      0xfc01	/* KEY_10CHANNELSUP */
> #define XK_Ab                0xfc02	/* KEY_AB */
> #define XK_Again             0xfc03	/* KEY_AGAIN */
> #define XK_Angle             0xfc04	/* KEY_ANGLE */
> #define XK_Audio             0xfc05	/* KEY_AUDIO */
> #define XK_Aux               0xfc06	/* KEY_AUX */
> ...
> 
> to /usr/include/X11/keysymdef.h and use those new symbol internals
> inside the media userspace applications.
> 
> However, for this to work, for each of the used codes, an specific
> behavior should be used by the media applications.
> 
> If we look on the places that use KEY_PROG1, we have (before this patch series):
...
> So, a code like KEY_PROG1 can't be translated into anything useful,
> and, even if we create a "XK_Prog1", the translation for Xorg, its
> translation inside the applications is not obvious at all. So, we
> should really avoid things like that inside the keymaps.
> 
> Perhaps using KEY_LEFTMETA is not a good idea to map the Windows MCE
> key, but, in this case, we should create another keycode inside evdev
> and export it to userspace.

As discussed on irc, KEY_MEDIA seems like the best answer. There's
something in the mce keymap already mapped to KEY_MEDIA, but I don't
seem to have that key on either of the mce remotes I have handy at
the moment, so its probably on one of the less common remotes... We
can change that key's mapping at a later date, if someone wants to
use that button for something different than the green button.

-- 
Jarod Wilson
jarod@xxxxxxxxxxxx



--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux