Re: [RFC PATCH 01/12] soc_camera: add control handler support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 19 Jan 2011, Guennadi Liakhovetski wrote:

> > @@ -963,15 +897,15 @@ static int soc_camera_probe(struct device *dev)
> >  	if (icl->reset)
> >  		icl->reset(icd->pdev);
> >  
> > -	ret = ici->ops->add(icd);
> > -	if (ret < 0)
> > -		goto eadd;
> > -
> >  	/* Must have icd->vdev before registering the device */
> >  	ret = video_dev_create(icd);
> >  	if (ret < 0)
> >  		goto evdc;
> >  
> > +	ret = ici->ops->add(icd);
> > +	if (ret < 0)
> > +		goto eadd;
> > +
> 
> Yes, this is something, I'll have to think about / have a look at / test.

Right, this looks harmless.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux