On Mon, Jan 17, 2011 at 02:17:58PM +0100, Stefan Richter wrote:
> After a recent update of xf86-input-evdev and xorg-server, I noticed
> that X11 applications did not receive keypresses from the FireDTV
> infrared remote control anymore. Instead, the Xorg log featured lots of
>
> "FireDTV remote control: dropping event due to full queue!"
>
> exclamations. The Linux console did not have an issue with the
> FireDTV's RC though.
>
> The fix is to insert EV_SYN events after the key-down/-up events.
> Dimitry notes that EV_SYN is also necessary between down and up,
> otherwise userspace could combine their state.
>
> Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
Acked-by: Dmitry Torokhov <dtor@xxxxxxx>
> ---
> drivers/media/dvb/firewire/firedtv-rc.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> Index: b/drivers/media/dvb/firewire/firedtv-rc.c
> ===================================================================
> --- a/drivers/media/dvb/firewire/firedtv-rc.c
> +++ b/drivers/media/dvb/firewire/firedtv-rc.c
> @@ -172,7 +172,8 @@ void fdtv_unregister_rc(struct firedtv *
>
> void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
> {
> - u16 *keycode = fdtv->remote_ctrl_dev->keycode;
> + struct input_dev *idev = fdtv->remote_ctrl_dev;
> + u16 *keycode = idev->keycode;
>
> if (code >= 0x0300 && code <= 0x031f)
> code = keycode[code - 0x0300];
> @@ -188,6 +189,8 @@ void fdtv_handle_rc(struct firedtv *fdtv
> return;
> }
>
> - input_report_key(fdtv->remote_ctrl_dev, code, 1);
> - input_report_key(fdtv->remote_ctrl_dev, code, 0);
> + input_report_key(idev, code, 1);
> + input_sync(idev);
> + input_report_key(idev, code, 0);
> + input_sync(idev);
> }
>
>
> --
> Stefan Richter
> -=====-==-== ---= =---=
> http://arcgraph.de/sr/
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
