Hi, On Tue, Jan 11, 2011 at 06:31:21AM -0500, manjunatha_halli@xxxxxx wrote: > From: Manjunatha Halli <manjunatha_halli@xxxxxx> > > These are common headers used in FM submodules (FM V4L2, > FM common, FM Rx,and FM TX). > > Signed-off-by: Manjunatha Halli <manjunatha_halli@xxxxxx> > Reviewed-by: Hans Verkuil <hverkuil@xxxxxxxxx> snip > diff --git a/drivers/media/radio/wl128x/fmdrv.h b/drivers/media/radio/wl128x/fmdrv.h > new file mode 100644 > index 0000000..392b62d > --- /dev/null > +++ b/drivers/media/radio/wl128x/fmdrv.h > @@ -0,0 +1,244 @@ > +/* > + * FM Driver for Connectivity chip of Texas Instruments. > + * > + * Common header for all FM driver sub-modules. > + * > + * Copyright (C) 2011 Texas Instruments > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > + * > + */ > + > +#ifndef _FM_DRV_H > +#define _FM_DRV_H > + > +#include <linux/skbuff.h> > +#include <linux/interrupt.h> > +#include <sound/core.h> > +#include <sound/initval.h> > +#include <linux/timer.h> > +#include <linux/version.h> > +#include <media/v4l2-ioctl.h> > +#include <media/v4l2-common.h> > +#include <media/v4l2-ctrls.h> > + > +#define FM_DRV_VERSION "0.09" > +/* Should match with FM_DRV_VERSION */ > +#define FM_DRV_RADIO_VERSION KERNEL_VERSION(0, 0, 1) > +#define FM_DRV_NAME "ti_fmdrv" > +#define FM_DRV_CARD_SHORT_NAME "TI FM Radio" > +#define FM_DRV_CARD_LONG_NAME "Texas Instruments FM Radio" > + > +/* Flag info */ > +#define FM_INTTASK_RUNNING 0 > +#define FM_INTTASK_SCHEDULE_PENDING 1 > +#define FM_FW_DW_INPROGRESS 2 > +#define FM_CORE_READY 3 > +#define FM_CORE_TRANSPORT_READY 4 > +#define FM_AF_SWITCH_INPROGRESS 5 > +#define FM_CORE_TX_XMITING 6 > + > +#define FM_TUNE_COMPLETE 0x1 > +#define FM_BAND_LIMIT 0x2 > + > +#define FM_DRV_TX_TIMEOUT (5*HZ) /* 5 seconds */ > +#define FM_DRV_RX_SEEK_TIMEOUT (20*HZ) /* 20 seconds */ > + > +#define NO_OF_ENTRIES_IN_ARRAY(array) (sizeof(array) / sizeof(array[0])) this is called ARRAY_SIZE(), just use it. > + > +#define fmerr(format, ...) \ > + printk(KERN_ERR "fmdrv: " format, ## __VA_ARGS__) > +#define fmwarn(format, ...) \ > + printk(KERN_WARNING "fmdrv: " format, ##__VA_ARGS__) > +#ifdef DEBUG > +#define fmdbg(format, ...) \ > + printk(KERN_DEBUG "fmdrv: " format, ## __VA_ARGS__) > +#else /* DEBUG */ > +#define fmdbg(format, ...) > +#endif why don't you use dev_dbg(), dev_err() and dev_warn() ?? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
