On 07-01-2011 17:13, Hadli, Manjunath wrote:
This patch implements the overall device creation for the Video
display driver.
Signed-off-by: Manjunath Hadli<manjunath.hadli@xxxxxx>
Acked-by: Muralidharan Karicheri<m-karicheri2@xxxxxx>
Acked-by: Hans Verkuil<hverkuil@xxxxxxxxx>
[...]
diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h
b/arch/arm/mach-davinci/include/mach/dm644x.h
index 5a1b26d..b59591c 100644
--- a/arch/arm/mach-davinci/include/mach/dm644x.h
+++ b/arch/arm/mach-davinci/include/mach/dm644x.h
[...]
@@ -40,8 +43,21 @@
#define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000
#define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000
+/* VPBE register base addresses */
+#define DM644X_VENC_REG_BASE 0x01C72400
You defined the macro but don't use it...
+#define DM644X_VPBE_REG_BASE 0x01C72780
+
+#define DM644X_OSD_REG_BASE 0x01C72600
Same comment...
+#define DM644X_VPBE_REG_BASE 0x01C72780
This is duplicate.
+
+#define OSD_REG_SIZE 0x00000100
Your OSD platform device however has its resource of size 0x200...
+/* SYS register addresses */
+#define SYS_VPSS_CLKCTL 0x01C40044
You've already #define'd and used VPSS_CLKCTL -- this is duplicate/unused.
We are using the base addresses from platform resources. I will delete these.
You could use these macros to #define the platfrom resources, if you
#define'd them already.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
