Hi Jon, Laurent, This patch series converts the OLPC cafe_ccic driver to the new control framework. It turned out that this depended on the removal of the legacy s_config subdev operation. I originally created the ov7670 controls in s_config, but it turned out that s_config is called after v4l2_device_register_subdev, so v4l2_device_register_subdev is unable to 'inherit' the ov7670 controls in cafe_ccic since there aren't any yet. Another reason why s_config is a bad idea. So the first patch removes s_config and v4l2_i2c_new_subdev_cfg and converts any users (cafe_ccic/ov7670 among them) to v4l2_i2c_new_subdev_board, which is what God (i.e. Jean Delvare) intended. :-) The second patch adds the (un)register internal ops allowing subdev drivers to do some work after the subdevice is registered with a v4l2_device. So here the sd->v4l2_dev pointer is set. Laurent, is this sufficient for the upcoming omap3 sub-devices? The third patch fixes a small bug in v4l2_ctrl_handler_setup() that is required for the ov7670 conversion. This bug does not affect any existing drivers. The last two patches convert ov7670 and cafe_ccic to the V4L2 control framework. This saves over a 100 lines of code and adds full support of the control API (including extended controls) to the drivers. This has been extensively tested on my humble OLPC laptop (and it took me 4-5 hours just to get the damn thing up and running with these drivers). Special attention was given to the handling of gain/autogain and exposure/autoexposure. The way this works is that setting the gain on its own will turn off autogain (this conforms to the current behavior of ov7670), setting autogain and gain atomically will only set the gain if autogain is set to manual. Ditto for exposure/autoexposure. The only question is: is the current behavior of implicitly turning off autogain when setting a new gain value correct? I think setting the gain in that case should do nothing. On the other hand, I don't know if there is any code that depends on this behavior, so perhaps we should just leave it as is. Jon, can you take a look and let me know if it is OK with you? Regards, Hans ov7670.c | 296 ++++++++++++++++++++++++--------------------------------------- 1 file changed, 116 insertions(+), 180 deletions(-) cafe_ccic.c | 59 +++++++++++------------------------------------------------ 1 file changed, 11 insertions(+), 48 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
