Hi Kamil, Kamil Debski wrote: > Hi, > > Thanks for the comment. Some of them include my code, which will I comment > below. > > > My review also imply Kamil's original patch. > <snip> > > > > > +#define MFC_NUM_CONTEXTS 4 > > > > How about use MFC_NUM_INSTANT instead MFC_NUM_CONTEXTS ? > > Because too many terms can make confusion. > > An instance means an MFC HW instance. Context is used for each open file handle. I know that. But as I know each handle can have only single MFC H/W instance. So I wish to reduce the terms. Is there anything I missed ? <snip> > > > > What's the difference btw num and inst_no ? > > It looks very similar. > > The inst_no is the number of hardware instance in MFC. Num on the other hand is > the number of context used by an open file handle. The inst_no made by MFC H/W has the same rule with num made by your code. So in my opinion it is always the same. How do you think about that ? <snip> > > Best wishes, > -- > Kamil Debski > Linux Platform Group > Samsung Poland R&D Center -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
