On Wed, 2011-01-05 at 13:50 +0100, Jean Delvare wrote: > On Tue, 28 Dec 2010 20:46:13 -0500, Andy Walls wrote: > > > > Add I2C registration of the Zilog Z8F0811 IR microcontroller for either > > lirc_zilog or ir-kbd-i2c to use. This is a required step in removing > > lirc_zilog's use of the deprecated struct i2c_adapter.id field. > > > > Signed-off-by: Andy Walls <awalls@xxxxxxxxxxxxxxxx> > > --- > > drivers/media/video/hdpvr/hdpvr-core.c | 5 +++ > > drivers/media/video/hdpvr/hdpvr-i2c.c | 53 ++++++++++++++++++++++++++++++++ > > drivers/media/video/hdpvr/hdpvr.h | 6 +++ > > 3 files changed, 64 insertions(+), 0 deletions(-) > > Looks good to me (even though it looks strange to update code which is > apparently disabled for quite a while...) Yes it is odd. My intent was ensure that after removal of adap->id, that the hdpvr driver would, in the future, identify its device in a manner lirc_zilog was expecting. I don't have a HD PVR with which to test things myself. So putting in all the plumbing lowers the barrier for developers like Jarrod or Janne to test lirc_zilog with an HD PVR when/if they re-enable I2C in hdpvr. Regards, Andy > Acked-by: Jean Delvare <khali@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
