Re: [RFCv2 PATCH 07/10] radio-mr800: remove autopm support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday, January 03, 2011 20:09:03 David Ellingsworth wrote:
> From my understanding, auto power management is for automatically
> suspending and resuming a driver whenever it is idle. Obviously this
> is a bad for this type of driver as it would turn off the radio
> whenever it was idle. It is not necessary to remove suspend/resume
> support in order to drop auto power management from this driver.

You are completely correct. The mr800 conversion was quick and dirty and
was meant to demonstrate how to add priority support in this driver.

The final version will only remove the autopm, not the suspend/resume.

Regards,

	Hans

> In
> fact doing so would be a mistake in my opinion. The current
> suspend/resume cycle ensures the radio if off during suspend, and
> restores it's last state during resume. These changes would leave the
> radio in it's current state, consuming power if it were on, while the
> system is suspended. This is a drastic deviation from the current
> behavior and would most likely not be appreciated by users that expect
> the device to go off during suspend and back on after resume. I NACK
> this change due to the complete removal of suspend/resume support.
> 
> Regards,
> 
> David Ellingsworth
> 

-- 
Hans Verkuil - video4linux developer - sponsored by Cisco
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux