On Friday, December 31, 2010 12:01:17 Mauro Carvalho Chehab wrote: > Em 29-12-2010 19:43, Hans Verkuil escreveu: > > This patch series adds two new features to the V4L2 framework. > > > > The first 5 patches add support for VIDIOC_G/S_PRIORITY. All prio handling > > will be done in the core for any driver that either uses struct v4l2_fh > > (ivtv only at the moment) or has no open and release file operations (true > > for many simple (radio) drivers). In all other cases the driver will have > > to do the work. > > It doesn't make sense to implement this at core, and for some this will happen > automatically, while, for others, drivers need to do something. However, it makes it possible to gradually convert all drivers. > > Eventually all drivers should either use v4l2_fh or never set filp->private_data. > > I made a series of patches, due to BKL stuff converting the core to always > use v4l2_fh on all drivers. This seems to be the right solution for it. Can you point me to those patches? I remember seeing them, but can't remember where. I see two potential problems with this approach: 1) A lot of drivers do not actually need to allocate a v4l2_fh struct, so it wastes memory. But on the other hand, it would be nicely consistent. 2) I prefer for core changes to have the least possible impact to existing drivers, and just convert existing drivers one by one. But I would have to see your patch series again to see the impact of such a change. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
