Re: [PATCH 5/5] media: intel/ipu6: Remove unused dev field from ipu6_isys_queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 13, 2025 at 11:24:27AM +0100, Stanislaw Gruszka wrote:
> With current code base dev is only writend but never read.

s/writend/written/

Maybe add: Remove it as redundant.

> 
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys-queue.c | 1 -
>  drivers/media/pci/intel/ipu6/ipu6-isys-queue.h | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> index c7f302df2dcc..dd11eae1eeca 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
> @@ -841,7 +841,6 @@ int ipu6_isys_queue_init(struct ipu6_isys_queue *aq)
>  	if (ret)
>  		return ret;
>  
> -	aq->dev = &adev->auxdev.dev;
>  	aq->vbq.dev = &adev->isp->pdev->dev;
>  	spin_lock_init(&aq->lock);
>  	INIT_LIST_HEAD(&aq->active);
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.h b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.h
> index 1a277b0fb4b5..b865428a0fce 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-queue.h
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-queue.h
> @@ -20,7 +20,6 @@ struct ipu6_isys_stream;
>  struct ipu6_isys_queue {
>  	struct vb2_queue vbq;
>  	struct list_head node;
> -	struct device *dev;
>  	/*
>  	 * @lock: serialise access to queued and pre_streamon_queued
>  	 */

-- 
Sakari Ailus




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux