On Thu, 13 Mar 2025 at 10:52, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > On 13/03/2025 10:05, Andy Shevchenko wrote: > > On Wed, Mar 12, 2025 at 02:06:16PM -0700, Patchwork Integration wrote: > >> Dear Andy Shevchenko: > >> > >> Thanks for your patches! Unfortunately the Media CI robot detected some > >> issues: > >> > >> # Test media-patchstyle:./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch media style > >> ERROR: ./0001-media-v4l2-core-Replace-the-check-for-firmware-regis.patch: Missing 'media:' prefix in Subject > > > > LOL, what? > > Hmm, the 'I²C' bit in the Subject header causes it to be UTF-8. The Subject line in > patchwork (1) is now: > > Subject: [PATCH v2 1/1] =?utf-8?q?media=3A_v4l2-core=3A_Replace_the_check_fo?= > =?utf-8?q?r_firmware_registered_I=C2=B2C_devices?= > > so the check for the 'media:' prefix in the Subject line fails. > > Interestingly, if I commit the patch (git am) to a test branch, then run > 'git format-patch -n1' the Subject line now reads: > > Subject: [PATCH 1/1] =?UTF-8?q?media:=20v4l2-core:=20Replace=20the=20check?= > =?UTF-8?q?=20for=20firmware=20registered=20I=C2=B2C=20devices?= > > and that restored the ':'. > > Ricardo, can you look at this? STOP breaking media-ci :P [1] Thanks for the report. We were not ready to handle that encoding. I am now leveraging "git log" and it seems to work fine. https://gitlab.freedesktop.org/linux-media/media-ci/-/merge_requests/246 Regards > > I also noticed that the v1 and v2 patches ended up in my spam folder. Whether that > is related to UTF-8 in the Subject is not clear (my provider marks way too many > legit posts as spam). > > Andy, can you post a v3 with just 'I2C' in the subject instead of 'I²C'? If nothing > else, I'd like to know if that's the reason it ended up in my spam folder. > > Regards, > > Hans > > (1) https://patchwork.linuxtv.org/project/linux-media/patch/20250312192528.95838-1-andriy.shevchenko@xxxxxxxxxxxxxxx/ > > > > >> Please fix your series, and upload a new version. If you have a patchwork > >> account, do not forget to mark the current series as Superseded. > >> > >> For more details, check the full report at: > >> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/72774130/artifacts/report.htm . > > > [1] No, seriously, thanks for taking the time to report back, it really helps! -- Ricardo Ribalda
