On Sun, Mar 09, 2025 at 10:47:56AM +0200, Cosmin Tanislav wrote: > MAX96717 is capable of configuring various pin properties. > > Add pinctrl/pinconf properties to support this usecase. > > Signed-off-by: Cosmin Tanislav <demonsingur@xxxxxxxxx> > --- > .../media/i2c/maxim,max96717-pinctrl.yaml | 71 +++++++++++++++++++ > .../bindings/media/i2c/maxim,max96717.yaml | 16 ++++- > MAINTAINERS | 1 + > 3 files changed, 87 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml > new file mode 100644 > index 000000000000..347e66a5320c > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96717-pinctrl.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2025 Analog Devices Inc. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/maxim,max96717-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim GMSL2 Serializer Pinctrl > + > +maintainers: > + - Cosmin Tanislav <cosmin.tanislav@xxxxxxxxxx> > + > +allOf: > + - $ref: /schemas/pinctrl/pincfg-node.yaml# > + - $ref: /schemas/pinctrl/pinmux-node.yaml# > + > +unevaluatedProperties: false > + > +properties: > + function: true > + pins: true > + drive-open-drain: true > + drive-push-pull: true > + bias-disable: true > + bias-pull-up: true > + bias-pull-down: true > + output-disable: true > + output-enable: true > + output-low: true > + output-high: true > + slew-rate: true > + input-enable: true > + > + maxim,jitter-compensation: > + type: boolean > + description: Enables jitter compensation. > + > + maxim,gmsl-tx: > + type: boolean > + description: Enable transmitting pin value to GMSL link. > + > + maxim,gmsl-rx: > + type: boolean > + description: Enable receiving pin value from GMSL link. > + > + maxim,gmsl-tx-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Identifier used while transmitting value to GMSL link. > + Default value matches the pin number. Use normally wrapping or blank line between paragraphs. > + minimum: 0 > + maximum: 31 > + > + maxim,gmsl-rx-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Identifier used while receiving value from GMSL link. > + Default value matches the pin number. > + minimum: 0 > + maximum: 31 > + > + maxim,rclkout-clock: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Clock value. > + 0 - XTAL / 1 = 25MHz > + 1 - XTAL / 2 = 12.5MHz > + 2 - XTAL / 4 = 6.25MHz > + 3 - Reference PLL output > + minimum: 0 > + maximum: 3 > diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml > index dd28cc397674..0a43582168a8 100644 > --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml > @@ -120,7 +120,21 @@ required: > - reg > - ports > > -additionalProperties: false > +additionalProperties: > + anyOf: > + - type: object > + allOf: > + - $ref: /schemas/media/i2c/maxim,max96717-pinctrl.yaml# You can drop the allOf here. > + > + unevaluatedProperties: false > + > + - type: object > + additionalProperties: > + type: object > + allOf: > + - $ref: /schemas/media/i2c/maxim,max96717-pinctrl.yaml# And here. > + > + unevaluatedProperties: false Do you really need to support 2 forms? This also allows the node names to be anything. We do that for existing cases, but for new ones you should define some prefix or suffix. Typically, '-pins$' is used. Rob
