On 3/7/25 12:54, Hans Verkuil wrote: > Hi Dmitry, > > On 07/03/2025 10:21, Dmitry Osipenko wrote: >> The pixelclock is specified as 64bit integer and for this driver it >> won't be above 600MHz. Fix the 64bit division of the pixclock for 32bit >> kernel builds. >> >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> Closes: https://lore.kernel.org/oe-kbuild-all/202503070743.WnRxStlk-lkp@xxxxxxxxx/ >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> >> --- >> drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c >> index 4d42da7255f3..7e342bbde967 100644 >> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c >> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c >> @@ -291,7 +291,7 @@ static void hdmirx_get_timings(struct snps_hdmirx_dev *hdmirx_dev, >> hfp = htotal - hact - hs - hbp; >> vfp = vtotal - vact - vs - vbp; >> >> - fps = (bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal); >> + fps = ((u32)bt->pixelclock + (htotal * vtotal) / 2) / (htotal * vtotal); > > I just merged: > > https://patchwork.linuxtv.org/project/linux-media/patch/20250306-synopsys-hdmirx-fix-64-div-v1-1-dd5ff38bba5e@xxxxxxxxxx/ > > So you can either leave that patch in, or provide a patch on top. Missed that patch you merged. No need to do anything then, thanks! -- Best regards, Dmitry
