Re: [PATCH] media: vim2m: print device name after registering device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/6/25 01:37, Hans Verkuil wrote:
Hi Shuah,

On 20/02/2025 17:27, Shuah Khan wrote:
On 2/20/25 08:29, Matthew Majewski wrote:
On Wed, 2025-02-19 at 17:21 -0700, Shuah Khan wrote:
On 2/19/25 14:58, Uwe Kleine-Konig wrote:
On Wed, Feb 19, 2025 at 02:05:01PM -0500, Matthew Majewski wrote:
Move the v4l2_info() call displaying the video device name after
the
device is actually registered.

This fixes a bug where the driver was always displaying
"/dev/video0"
since it was reading from the vfd before it was registered.

Signed-off-by: Matthew Majewski <mattwmajewski@xxxxxxxxx>

A Fixes: tag would be great.

Matthew, there is no need to resend the patch. Just send me the
Fixes tag and I will update the repo.



Ok, here is the fixes tag:

Fixes: cf7f34777a5b4100a ("media: vim2m: Register video device after
setting up internals")


Thank you. commit is now updated.

thanks,
-- Shuah


Please post your PR today, if possible. Otherwise it might slip to the
v6.16. Alternatively, I can take this patch myself.

Thanks for the reminder - I have to send a vimc PR

Please take this through your tree.


Also, why did you pick up this vim2m patch? I was a bit surprised by that.

By mistake - Blame it on jet lag - sorry. Explains why Matthew sent series
for my review.

thanks,
-- Shuah




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux