From: "tarang.raval" <tarang.raval@xxxxxxxxxxxxxxxxx>
This patch ensures that runtime PM is fully initialized before
calling v4l2_async_register_subdev_sensor(). Moving the runtime
PM initialization earlier prevents potential access to an
uninitialized or powered-down device.
Additionally, enables autosuspend
Signed-off-by: tarang.raval <tarang.raval@xxxxxxxxxxxxxxxxx>
---
drivers/media/i2c/imx219.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 2d54cea113e1..bdb5fd5778a0 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -1178,6 +1178,11 @@ static int imx219_probe(struct i2c_client *client)
goto error_media_entity;
}
+ /* Enable runtime PM and turn off the device */
+ pm_runtime_set_active(dev);
+ pm_runtime_enable(dev);
+ pm_runtime_idle(dev);
+
ret = v4l2_async_register_subdev_sensor(&imx219->sd);
if (ret < 0) {
dev_err_probe(dev, ret,
@@ -1185,14 +1190,14 @@ static int imx219_probe(struct i2c_client *client)
goto error_subdev_cleanup;
}
- /* Enable runtime PM and turn off the device */
- pm_runtime_set_active(dev);
- pm_runtime_enable(dev);
- pm_runtime_idle(dev);
+ pm_runtime_set_autosuspend_delay(dev, 1000);
+ pm_runtime_use_autosuspend(dev);
return 0;
error_subdev_cleanup:
+ pm_runtime_disable(&client->dev);
+ pm_runtime_set_suspended(&client->dev);
v4l2_subdev_cleanup(&imx219->sd);
error_media_entity:
--
2.34.1
