Hi Sakari,
> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Sent: Monday, March 3, 2025 1:26 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@xxxxxxxxxxxxx>
> Cc: mchehab@xxxxxxxxxx; kieran.bingham@xxxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Conor Dooley -
> M52691 <Conor.Dooley@xxxxxxxxxxxxx>; Valentina Fernandez Alanis -
> M63239 <Valentina.FernandezAlanis@xxxxxxxxxxxxx>; Praveen Kumar -
> I30718 <Praveen.Kumar@xxxxxxxxxxxxx>
> Subject: Re: [PATCH V6 1/3] media: i2c: imx334: Optimized 4k and 2k mode
> register arrays
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Mon, Mar 03, 2025 at 07:54:58AM +0000, Sakari Ailus wrote:
> > Hi Shravan,
> >
> > On Sat, Mar 01, 2025 at 12:56:55AM +0000,
> Shravan.Chippa@xxxxxxxxxxxxx wrote:
> > > Hi Sakari,
> > >
> > > > -----Original Message-----
> > > > From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > > > Sent: Friday, February 28, 2025 5:19 PM
> > > > To: shravan Chippa - I35088 <Shravan.Chippa@xxxxxxxxxxxxx>
> > > > Cc: mchehab@xxxxxxxxxx; kieran.bingham@xxxxxxxxxxxxxxxx; linux-
> > > > media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Conor Dooley
> > > > -
> > > > M52691 <Conor.Dooley@xxxxxxxxxxxxx>; Valentina Fernandez Alanis -
> > > > M63239 <Valentina.FernandezAlanis@xxxxxxxxxxxxx>; Praveen Kumar -
> > > > I30718 <Praveen.Kumar@xxxxxxxxxxxxx>
> > > > Subject: Re: [PATCH V6 1/3] media: i2c: imx334: Optimized 4k and
> > > > 2k mode register arrays
> > > >
> > > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > > know the content is safe
> > > >
> > > > Hi Shravan,
> > > >
> > > > On Fri, Feb 28, 2025 at 04:03:30PM +0530, shravan kumar wrote:
> > > > > From: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
> > > > >
> > > > > Optimized the resolution arrays by integrating a common register array.
> > > > >
> > > > > Adjusted the register array values for 1920x1080@30 and
> > > > > 3840x2160@30 resolutions to align with the common register array
> values.
> > > > >
> > > > > Signed-off-by: Shravan Chippa <shravan.chippa@xxxxxxxxxxxxx>
> > > > > ---
> > > > > drivers/media/i2c/imx334.c | 132
> > > > > +++++++++----------------------------
> > > > > 1 file changed, 31 insertions(+), 101 deletions(-)
> > > > >
> > > > > diff --git a/drivers/media/i2c/imx334.c
> > > > > b/drivers/media/i2c/imx334.c index a544fc3df39c..a800f2203592
> > > > > 100644
> > > > > --- a/drivers/media/i2c/imx334.c
> > > > > +++ b/drivers/media/i2c/imx334.c
> > > > > @@ -167,8 +167,8 @@ static const s64 link_freq[] = {
> > > > > IMX334_LINK_FREQ_445M,
> > > > > };
> > > > >
> > > > > -/* Sensor mode registers for 1920x1080@30fps */ -static const
> > > > > struct imx334_reg mode_1920x1080_regs[] = {
> > > > > +/* Sensor common mode registers values */ static const struct
> > > > > +imx334_reg common_mode_regs[] = {
> > > > > {0x3000, 0x01},
> > > > > {0x3018, 0x04},
> > > > > {0x3030, 0xca},
> > > > > @@ -176,26 +176,10 @@ static const struct imx334_reg
> > > > mode_1920x1080_regs[] = {
> > > > > {0x3032, 0x00},
> > > > > {0x3034, 0x4c},
> > > > > {0x3035, 0x04},
> > > > > - {0x302c, 0xf0},
> > > > > - {0x302d, 0x03},
> > > > > - {0x302e, 0x80},
> > > > > - {0x302f, 0x07},
> > > > > - {0x3074, 0xcc},
> > > > > - {0x3075, 0x02},
> > > > > - {0x308e, 0xcd},
> > > > > - {0x308f, 0x02},
> > > > > - {0x3076, 0x38},
> > > > > - {0x3077, 0x04},
> > > > > - {0x3090, 0x38},
> > > > > - {0x3091, 0x04},
> > > > > - {0x3308, 0x38},
> > > > > - {0x3309, 0x04},
> > > > > - {0x30C6, 0x00},
> > > > > + {0x30c6, 0x00},
> > > > > {0x30c7, 0x00},
> > > > > {0x30ce, 0x00},
> > > > > {0x30cf, 0x00},
> > > > > - {0x30d8, 0x18},
> > > > > - {0x30d9, 0x0a},
> > > > > {0x304c, 0x00},
> > > > > {0x304e, 0x00},
> > > > > {0x304f, 0x00},
> > > > > @@ -210,7 +194,7 @@ static const struct imx334_reg
> > > > mode_1920x1080_regs[] = {
> > > > > {0x300d, 0x29},
> > > > > {0x314c, 0x29},
> > > > > {0x314d, 0x01},
> > > > > - {0x315a, 0x06},
> > > > > + {0x315a, 0x0a},
> > > >
> > > > We still have this change in the patch that's just supposed to
> > > > move register address/value pairs around. :-( Please check the
> > > > changes yourself before posting v7.
> > >
> > > Do I need to split the patch or drop this change ? in v7
> >
> > Either way but it does not belong here.
>
> Oh, and btw. if you want to make the change, then I think you'll need to make
> HBLANK configurable with the default being the original value.
Ok, I will change according to datasheet with respect link frequency in V7.
As of now, I will not be able to do configurable HBLANK changes in this driver.
Thanks,
Shravan
>
> --
> Sakari Ailus
