Hi Jacopo,
Thank you for the patch.
On Mon, Feb 24, 2025 at 09:19:42PM +0100, Jacopo Mondi wrote:
> The VSPX generates "FRame End" (FRE) interrutps, one for each
> buffer transferred to the ISP.
>
> Even if the FRE interrupt is not enabled, it is reported as active
> in the interrupt status register.
>
> Make sure to clean it when handling the interrupt.
This doesn't seem to match the code code.
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/vsp1/vsp1_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> index d13e9b31aa7cff8610ea196ae4de88ab22e44e0f..17ace4c6844d19aaafc27e79f016cc05091372bf 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> @@ -69,7 +69,8 @@ static irqreturn_t vsp1_irq_handler(int irq, void *data)
> i, wpf->entity.pipe->underrun_count);
> }
>
> - if (status & VI6_WPF_IRQ_STA_DFE) {
> + if (status & VI6_WPF_IRQ_STA_DFE ||
> + status & VI6_WPF_IRQ_STA_FRE) {
> vsp1_pipeline_frame_end(wpf->entity.pipe);
> ret = IRQ_HANDLED;
> }
>
--
Regards,
Laurent Pinchart
